Conversation
e539b6c to
9f98227
Compare
ormsbee
left a comment
There was a problem hiding this comment.
This is labeled as a WIP, so I'll check back again when it's ready for final review. Everything seems reasonable though. My only high level comment is that this is three different tickets of work, and that it would be better to deliver as different PRs as well (less risk, easier to track down changes, faster user feedback, etc.)
aafd54d to
b99d45f
Compare
marcotuts
left a comment
There was a problem hiding this comment.
5 different minor changes flagged here, mostly small styling notes. the first one is the largest as once the modals are 95% for all component editing views it might require testing / review of all the other modals before final merge.
b99d45f to
7b2bd2f
Compare
7b2bd2f to
d6b1285
Compare
|
jenkins run bokchoy python quality |
|
jenkins run python |
8cb995a to
81e2b22
Compare
ormsbee
left a comment
There was a problem hiding this comment.
Small question on some commented code, but otherwise LGTM. Please squash and add some context from the JIRA ticket into the commit message (what was done at a feature level and why), and let's merge. 😄
8a449d0 to
307b998
Compare
* Enlarges component modal for easier editing * Allows display name to be edited in place * Improves markdown button labeling * Moves markdown cheatsheet to the edit modal, for quick reference
307b998 to
ea3232f
Compare
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, September 27, 2019. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
https://openedx.atlassian.net/browse/TNL-6920